tiny/spring-state-machine-renderer
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fail closed on ambiguous simple enum names

Browse Source 
Track enum name collisions during scan and refuse to resolve enum values by simple name when multiple enums share the same identifier across packages.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Kamil Patryk Kozakowski
2026-07-13 21:51:22 +02:00
parent bbfb54c51b
commit f3c82d5d7f
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
state_machine_exporter/src/main/java/click/kamil/springstatemachineexporter/ast/common/CodebaseContext.java
View File

@@ -482,7 +482,12 @@ public class CodebaseContext {
}
}
enumValues.put(fqn, values);
if (!simpleNameToFqn.containsKey(simpleName)) {
if (simpleNameToFqn.containsKey(simpleName)) {
String existingFqn = simpleNameToFqn.get(simpleName);
if (existingFqn != null && !existingFqn.equals(fqn)) {
ambiguousSimpleNames.add(simpleName);
}
} else {
simpleNameToFqn.put(simpleName, fqn);
}
@@ -516,6 +521,9 @@ public class CodebaseContext {
List<String> values = enumValues.get(cleanName);
if (values == null) {
if (!cleanName.contains(".") && ambiguousSimpleNames.contains(cleanName)) {
return null;
}
String fqn = simpleNameToFqn.get(cleanName);
if (fqn != null) values = enumValues.get(fqn);
}

19
state_machine_exporter/src/test/java/click/kamil/springstatemachineexporter/ast/common/CodebaseContextTest.java
View File

@@ -231,6 +231,25 @@ class CodebaseContextTest {
assertThat(context.findEntryPointClasses(List.of("EnableStateMachine"))).isEmpty();
}
@Test
void getEnumValuesShouldFailClosedForAmbiguousSimpleEnumName() throws IOException {
Files.createDirectories(tempDir.resolve("a"));
Files.createDirectories(tempDir.resolve("b"));
Files.writeString(tempDir.resolve("a/OrderEvent.java"),
"package a; public enum OrderEvent { PAY }");
Files.writeString(tempDir.resolve("b/OrderEvent.java"),
"package b; public enum OrderEvent { SHIP }");
CodebaseContext context = new CodebaseContext();
context.scan(tempDir);
assertThat(context.getEnumValues("OrderEvent"))
.as("ambiguous simple enum name must not resolve to arbitrary package")
.isNull();
assertThat(context.getEnumValues("a.OrderEvent")).containsExactly("a.OrderEvent.PAY");
assertThat(context.getEnumValues("b.OrderEvent")).containsExactly("b.OrderEvent.SHIP");
}
@Test
void shouldFindClassWithFullyQualifiedAnnotation() throws IOException {
String source = """