Expand if-equals path bindings through static string constants.

Resolve ORDER.equals(machineType) and Objects.equals(CONST, param) by reusing compile-time static final string constant folding for both equals sides. Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-14 18:38:30 +02:00
parent 24cd248a22
commit 73f047e0aa
2 changed files with 152 additions and 14 deletions
--- a/state_machine_exporter/src/test/java/click/kamil/springstatemachineexporter/analysis/service/EntryPointBindingExpanderTest.java
+++ b/state_machine_exporter/src/test/java/click/kamil/springstatemachineexporter/analysis/service/EntryPointBindingExpanderTest.java
@@ -2585,4 +2585,116 @@ class EntryPointBindingExpanderTest {
        assertThat(variants).extracting(map -> map.get("commandKey"))
                .containsExactlyInAnyOrder("order.pay", "order.ship");
    }
+
+    @Test
+    void shouldExpandMachineTypeFromIfEqualsOnStaticFinalConstant(@TempDir Path tempDir) throws Exception {
+        String source = """
+            package com.example;
+            public class MachineController {
+                StateMachineDispatcher dispatcher;
+                public void transition(String machineType, String event) {
+                    dispatcher.dispatch(machineType, event);
+                }
+            }
+            class StateMachineDispatcher {
+                private static final String ORDER = "ORDER";
+                private static final String DOCUMENT = "DOCUMENT";
+                void dispatch(String machineType, String eventString) {
+                    if (ORDER.equals(machineType)) {
+                        OrderEvent.valueOf(eventString.toUpperCase());
+                    } else if (DOCUMENT.equalsIgnoreCase(machineType)) {
+                        DocumentEvent.valueOf(eventString.toUpperCase());
+                    }
+                }
+            }
+            enum OrderEvent { PAY, SHIP }
+            enum DocumentEvent { SUBMIT, APPROVE }
+            """;
+        Files.writeString(tempDir.resolve("App.java"), source);
+
+        CodebaseContext context = new CodebaseContext();
+        context.setResolveBindings(true);
+        context.scan(tempDir);
+
+        HeuristicCallGraphEngine engine = new HeuristicCallGraphEngine(context);
+        Map<String, List<click.kamil.springstatemachineexporter.analysis.model.CallEdge>> graph = engine.buildCallGraph();
+
+        EntryPoint entryPoint = EntryPoint.builder()
+                .className("com.example.MachineController")
+                .methodName("transition")
+                .name("POST /api/machine/{machineType}/transition/{event}")
+                .parameters(List.of(
+                        EntryPoint.Parameter.builder()
+                                .name("machineType")
+                                .type("String")
+                                .annotations(List.of("PathVariable"))
+                                .build(),
+                        EntryPoint.Parameter.builder()
+                                .name("event")
+                                .type("String")
+                                .annotations(List.of("PathVariable"))
+                                .build()))
+                .build();
+
+        List<Map<String, String>> variants =
+                EntryPointBindingExpander.expandPathVariableBindings(entryPoint, context, graph);
+
+        assertThat(variants.stream().map(v -> v.get("machineType")).distinct())
+                .containsExactlyInAnyOrder("ORDER", "DOCUMENT");
+    }
+
+    @Test
+    void shouldExpandCommandKeyFromSwitchExpressionWithCrossClassCaseConstants(@TempDir Path tempDir) throws Exception {
+        String source = """
+            package com.example;
+            public class GenericCommandController {
+                OrderGateway gateway;
+                public void execute(String commandKey) {
+                    gateway.trigger(commandKey);
+                }
+            }
+            class OrderGateway {
+                void trigger(String commandKey) {
+                    DomainCommand command = switch (commandKey) {
+                        case CommandKeys.PAY_KEY -> DomainCommand.ORDER_PAY;
+                        case CommandKeys.SHIP_KEY -> DomainCommand.ORDER_SHIP;
+                        default -> throw new IllegalArgumentException("Unknown command: " + commandKey);
+                    };
+                    StateMachine sm = new StateMachine();
+                    sm.sendEvent(command);
+                }
+            }
+            class CommandKeys {
+                static final String PAY_KEY = "order.pay";
+                static final String SHIP_KEY = "order.ship";
+            }
+            enum DomainCommand { ORDER_PAY, ORDER_SHIP }
+            class StateMachine { void sendEvent(DomainCommand command) {} }
+            """;
+        Files.writeString(tempDir.resolve("App.java"), source);
+
+        CodebaseContext context = new CodebaseContext();
+        context.setResolveBindings(true);
+        context.scan(tempDir);
+
+        HeuristicCallGraphEngine engine = new HeuristicCallGraphEngine(context);
+        Map<String, List<click.kamil.springstatemachineexporter.analysis.model.CallEdge>> graph = engine.buildCallGraph();
+
+        EntryPoint entryPoint = EntryPoint.builder()
+                .className("com.example.GenericCommandController")
+                .methodName("execute")
+                .name("POST /api/commands/{commandKey}")
+                .parameters(List.of(EntryPoint.Parameter.builder()
+                        .name("commandKey")
+                        .type("String")
+                        .annotations(List.of("PathVariable"))
+                        .build()))
+                .build();
+
+        List<Map<String, String>> variants =
+                EntryPointBindingExpander.expandPathVariableBindings(entryPoint, context, graph);
+
+        assertThat(variants).extracting(map -> map.get("commandKey"))
+                .containsExactlyInAnyOrder("order.pay", "order.ship");
+    }
 }